[BEAM-5949] Remove trivial __ne__ implementations.

sdks/python/apache_beam/coders/coders.py

@@ -292,10 +292,6 @@ def __eq__(self, other):
 
   # pylint: enable=protected-access
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash(type(self))
 

sdks/python/apache_beam/coders/coders_test.py

@@ -167,10 +167,6 @@ def __eq__(self, other):
       return True
     return False
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash(type(self))
 

sdks/python/apache_beam/coders/typecoders_test.py

@@ -37,10 +37,6 @@ def __init__(self, n):
   def __eq__(self, other):
     return self.number == other.number
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return self.number
 

sdks/python/apache_beam/dataframe/expressions.py

@@ -163,9 +163,6 @@ def __hash__(self):
   def __eq__(self, other):
     return self._id == other._id
 
-  def __ne__(self, other):
-    return not self == other
-
   def __repr__(self):
     return '%s[%s]' % (self.__class__.__name__, self._id)
 

sdks/python/apache_beam/dataframe/partitionings.py

@@ -82,9 +82,6 @@ def __repr__(self):
   def __eq__(self, other):
     return type(self) == type(other) and self._levels == other._levels
 
-  def __ne__(self, other):
-    return not self == other
-
   def __hash__(self):
     if self._levels:
       return hash(tuple(sorted(self._levels)))
@@ -142,9 +139,6 @@ class Singleton(Partitioning):
   def __eq__(self, other):
     return type(self) == type(other)
 
-  def __ne__(self, other):
-    return not self == other
-
   def __hash__(self):
     return hash(type(self))
 
@@ -164,9 +158,6 @@ class Nothing(Partitioning):
   def __eq__(self, other):
     return type(self) == type(other)
 
-  def __ne__(self, other):
-    return not self == other
-
   def __hash__(self):
     return hash(type(self))
 

sdks/python/apache_beam/internal/metrics/cells.py

@@ -109,10 +109,6 @@ def __eq__(self, other):
   def __hash__(self):
     return hash(self.data)
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __repr__(self):
     return '<HistogramResult({})>'.format(
         self.data.histogram.get_percentile_info())
@@ -147,10 +143,6 @@ def __eq__(self, other):
   def __hash__(self):
     return hash(self.histogram)
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __repr__(self):
     return 'HistogramData({})'.format(self.histogram.get_percentile_info())
 

sdks/python/apache_beam/internal/util.py

@@ -65,10 +65,6 @@ def __eq__(self, other):
     """
     return isinstance(other, ArgumentPlaceholder)
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash(type(self))
 

sdks/python/apache_beam/io/concat_source_test.py

@@ -87,10 +87,6 @@ def __eq__(self, other):
         type(self) == type(other) and self._start == other._start and
         self._end == other._end and self._split_freq == other._split_freq)
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
 
 class ConcatSourceTest(unittest.TestCase):
   def test_range_source(self):

sdks/python/apache_beam/io/filebasedsink.py

@@ -403,10 +403,6 @@ def __eq__(self, other):
     # pylint: disable=unidiomatic-typecheck
     return type(self) == type(other) and self.__dict__ == other.__dict__
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
 
 class FileBasedSinkWriter(iobase.Writer):
   """The writer for FileBasedSink.

sdks/python/apache_beam/io/filesystem.py

@@ -452,10 +452,6 @@ def __eq__(self, other):
   def __hash__(self):
     return hash((self.path, self.size_in_bytes))
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __repr__(self):
     return 'FileMetadata(%s, %s)' % (self.path, self.size_in_bytes)
 

sdks/python/apache_beam/io/gcp/pubsub.py

@@ -89,10 +89,6 @@ def __eq__(self, other):
     return isinstance(other, PubsubMessage) and (
         self.data == other.data and self.attributes == other.attributes)
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __repr__(self):
     return 'PubsubMessage(%s, %s)' % (self.data, self.attributes)
 

sdks/python/apache_beam/io/hadoopfilesystem_test.py

@@ -56,10 +56,6 @@ def __init__(self, path, mode='', type='FILE'):
   def __eq__(self, other):
     return self.stat == other.stat and self.getvalue() == self.getvalue()
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def close(self):
     self.saved_data = self.getvalue()
     io.BytesIO.close(self)

sdks/python/apache_beam/io/restriction_trackers.py

@@ -44,10 +44,6 @@ def __eq__(self, other):
 
     return self.start == other.start and self.stop == other.stop
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash((type(self), self.start, self.stop))
 

sdks/python/apache_beam/io/vcfio.py

@@ -140,10 +140,6 @@ def __init__(
   def __eq__(self, other):
     return isinstance(other, Variant) and vars(self) == vars(other)
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __repr__(self):
     return ', '.join([
         str(s) for s in [
@@ -238,10 +234,6 @@ def __eq__(self, other):
     return ((self.name, self.genotype, self.phaseset, self.info) == (
         other.name, other.genotype, other.phaseset, other.info))
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __repr__(self):
     return ', '.join(
         [str(s) for s in [self.name, self.genotype, self.phaseset, self.info]])

sdks/python/apache_beam/metrics/cells.py

@@ -286,11 +286,6 @@ def __hash__(self):
     # type: () -> int
     return hash(self.data)
 
-  def __ne__(self, other):
-    # type: (object) -> bool
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __repr__(self):
     # type: () -> str
     return 'DistributionResult(sum={}, count={}, min={}, max={})'.format(
@@ -345,11 +340,6 @@ def __hash__(self):
     # type: () -> int
     return hash(self.data)
 
-  def __ne__(self, other):
-    # type: (object) -> bool
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __repr__(self):
     return '<GaugeResult(value={}, timestamp={})>'.format(
         self.value, self.timestamp)
@@ -391,11 +381,6 @@ def __hash__(self):
     # type: () -> int
     return hash((self.value, self.timestamp))
 
-  def __ne__(self, other):
-    # type: (object) -> bool
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __repr__(self):
     # type: () -> str
     return '<GaugeData(value={}, timestamp={})>'.format(
@@ -457,11 +442,6 @@ def __hash__(self):
     # type: () -> int
     return hash((self.sum, self.count, self.min, self.max))
 
-  def __ne__(self, other):
-    # type: (object) -> bool
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __repr__(self):
     # type: () -> str
     return 'DistributionData(sum={}, count={}, min={}, max={})'.format(

sdks/python/apache_beam/metrics/execution.py

@@ -86,10 +86,6 @@ def __eq__(self, other):
         self.step == other.step and self.metric == other.metric and
         self.labels == other.labels)
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash((self.step, self.metric, frozenset(self.labels)))
 
@@ -129,10 +125,6 @@ def __eq__(self, other):
         self.key == other.key and self.committed == other.committed and
         self.attempted == other.attempted)
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash((self.key, self.committed, self.attempted))
 
@@ -193,9 +185,6 @@ def __eq__(self, other):
     return self is other or (
         self.cell_type == other.cell_type and self.fast_name == other.fast_name)
 
-  def __ne__(self, other):
-    return not self == other
-
   def __hash__(self):
     return self._hash
 

sdks/python/apache_beam/metrics/metricbase.py

@@ -82,10 +82,6 @@ def __eq__(self, other):
         self.namespace == other.namespace and self.name == other.name and
         self.urn == other.urn and self.labels == other.labels)
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __str__(self):
     if self.urn:
       return 'MetricName(namespace={}, name={}, urn={}, labels={})'.format(

sdks/python/apache_beam/options/value_provider.py

@@ -88,10 +88,6 @@ def __eq__(self, other):
         return True
     return False
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash((type(self), self.value_type, self.value))
 

sdks/python/apache_beam/pvalue.py

@@ -151,10 +151,6 @@ def __eq__(self, other):
     if isinstance(other, PCollection):
       return self.tag == other.tag and self.producer == other.producer
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash((self.tag, self.producer))
 
@@ -677,9 +673,6 @@ def __hash__(self):
   def __eq__(self, other):
     return type(self) == type(other) and self.__dict__ == other.__dict__
 
-  def __ne__(self, other):
-    return not self == other
-
   def __reduce__(self):
     return _make_Row, tuple(sorted(self.__dict__.items()))
 

sdks/python/apache_beam/runners/common.py

@@ -91,10 +91,6 @@ def __init__(self, step_name, transform_id=None):
   def __eq__(self, other):
     return self.step_name == other.step_name
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __repr__(self):
     return 'NameContext(%s)' % self.__dict__
 
@@ -134,10 +130,6 @@ def __eq__(self, other):
         self.user_name == other.user_name and
         self.system_name == other.system_name)
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash((self.step_name, self.user_name, self.system_name))
 

sdks/python/apache_beam/testing/test_stream.py

@@ -77,10 +77,6 @@ def __hash__(self):
   def __lt__(self, other):
     raise NotImplementedError
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   @abstractmethod
   def to_runner_api(self, element_coder):
     raise NotImplementedError

sdks/python/apache_beam/testing/util.py

@@ -75,10 +75,6 @@ def __init__(self, iterable):
     def __eq__(self, other):
       return self._counter == collections.Counter(other)
 
-    def __ne__(self, other):
-      # TODO(BEAM-5949): Needed for Python 2 compatibility.
-      return not self == other
-
     def __hash__(self):
       return hash(self._counter)
 

sdks/python/apache_beam/transforms/core.py

@@ -448,10 +448,6 @@ def __eq__(self, other):
       return self.param_id == other.param_id
     return False
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash(self.param_id)
 
@@ -2683,10 +2679,6 @@ def __eq__(self, other):
           self.environment_id == self.environment_id)
     return False
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash((
         self.windowfn,

sdks/python/apache_beam/transforms/cy_combiners.py

@@ -62,10 +62,6 @@ def __eq__(self, other):
         isinstance(other, AccumulatorCombineFn) and
         self._accumulator_type is other._accumulator_type)
 
-  def __ne__(self, other):
-    # TODO(BEAM-5949): Needed for Python 2 compatibility.
-    return not self == other
-
   def __hash__(self):
     return hash(self._accumulator_type)