Add tests for inherited ScalarFn subclasses.

apache · Dec 23, 2020 · b8d6204 · b8d6204
1 parent 3b593dc
commit b8d6204
Showing 1 changed file with 46 additions and 0 deletions.
diff --git a/...ions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/ScalarFnReflectorTest.java b/...ions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/ScalarFnReflectorTest.java
@@ -44,6 +44,16 @@ public void testGetApplyMethod() throws InvocationTargetException, IllegalAccess
     assertEquals(Long.valueOf(25L), result);
   }
 
+  @Test
+  @SuppressWarnings("nullness") // If result is null, test will fail as expected.
+  public void testGetApplyMethodOverride()
+      throws InvocationTargetException, IllegalAccessException {
+    IncrementFnChild incrementFn = new IncrementFnChild();
+    Method method = ScalarFnReflector.getApplyMethod(incrementFn);
+    @Nullable Object result = method.invoke(incrementFn, Long.valueOf(24L));
+    assertEquals(Long.valueOf(26L), result);
+  }
+
   @Test
   @SuppressWarnings("nullness") // If result is null, test will fail as expected.
   public void testGetApplyMethodStatic() throws InvocationTargetException, IllegalAccessException {
@@ -52,6 +62,20 @@ public void testGetApplyMethodStatic() throws InvocationTargetException, Illegal
     assertEquals(Long.valueOf(25L), result);
   }
 
+  @Test
+  public void testDifferentMethodNameThrowsIllegalArgumentException() {
+    thrown.expect(instanceOf(IllegalArgumentException.class));
+    thrown.expectMessage("Found multiple methods annotated with @ApplyMethod.");
+    ScalarFnReflector.getApplyMethod(new IncrementFnDifferentMethodName());
+  }
+
+  @Test
+  public void testDifferentMethodSignatureThrowsIllegalArgumentException() {
+    thrown.expect(instanceOf(IllegalArgumentException.class));
+    thrown.expectMessage("Found multiple methods annotated with @ApplyMethod.");
+    ScalarFnReflector.getApplyMethod(new IncrementFnDifferentSignature());
+  }
+
   @Test
   public void testMissingAnnotationThrowsIllegalArgumentException() {
     thrown.expect(instanceOf(IllegalArgumentException.class));
@@ -73,13 +97,35 @@ public Long increment(Long i) {
     }
   }
 
+  static class IncrementFnChild extends IncrementFn {
+    @ApplyMethod
+    @Override
+    public Long increment(Long i) {
+      return i + 2;
+    }
+  }
+
   static class IncrementFnWithStaticMethod extends ScalarFn {
     @ApplyMethod
     public static Long increment(Long i) {
       return i + 1;
     }
   }
 
+  static class IncrementFnDifferentMethodName extends IncrementFn {
+    @ApplyMethod
+    public Long differentMethod(Long i) {
+      return i + 2;
+    }
+  }
+
+  static class IncrementFnDifferentSignature extends IncrementFn {
+    @ApplyMethod
+    public Long increment(String s) {
+      return 0L;
+    }
+  }
+
   static class IncrementFnMissingAnnotation extends ScalarFn {
     public Long increment(Long i) {
       return i + 1;