Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
lukecwik committed Nov 30, 2022
1 parent 5a3ee7f commit fa1bd88
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ public class GroupIntoBatches<K, InputT>
*/
@AutoValue
public abstract static class BatchingParams<InputT> implements Serializable {
public static <InputT> BatchingParams<InputT> createDefault() {
private static <InputT> BatchingParams<InputT> createDefault() {
return new AutoValue_GroupIntoBatches_BatchingParams(
Long.MAX_VALUE, Long.MAX_VALUE, null, Duration.ZERO);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -183,8 +183,7 @@ public void testInGlobalWindowBatchSizeByteSizeFn() {

// to ensure ordered processing
TestStream.Builder<KV<String, String>> streamBuilder =
TestStream.create(KvCoder.of(StringUtf8Coder.of(), StringUtf8Coder.of()))
.advanceWatermarkTo(Instant.EPOCH);
TestStream.create(KvCoder.of(StringUtf8Coder.of(), StringUtf8Coder.of()));

long offset = 0L;
for (KV<String, String> kv : data) {
Expand Down

0 comments on commit fa1bd88

Please sign in to comment.