Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go code should get standard URNs from proto annotations #18951

Open
kennknowles opened this issue Jun 3, 2022 · 0 comments
Open

Go code should get standard URNs from proto annotations #18951

kennknowles opened this issue Jun 3, 2022 · 0 comments

Comments

@kennknowles
Copy link
Member

#4672 makes standard URNs of various Beam entities be defined in annotations on some enums in the protos. Java and Python now don't hard-code the URNs, instead they get them from the proto annotations.

However, Go still hard-codes the URNs. This JIRA is to make Go do something like what Java and Python do.

(I tried coding this up, but couldn't come up with a good Go API for this - the Java and Python ways don't translate into idiomatic Go as far as I can tell; it's also complicated by the fact that Go protobuf compiler currently doesn't give easy access to enum descriptors: golang/protobuf#364)

Imported from Jira BEAM-4179. Original Jira may contain additional context.
Reported by: jkff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants