You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have BatchConverterTest in batch.py, which is used to test the list and numpy implementations. As more BatchConverter implementations are added they will need to add tests that are almost identical to this one, with a few alterations:
The test data, currently handled with parameterized_class.
Possibly a custom equality check (e.g. pd.testing.assert_frame_equal for pandas)
We should make it possible to re-use the tests in BatchConverterTest without copy-pasting it, as this will lead to fragmentation.
Issue Priority
Priority: 2
Issue Component
Component: dsl-dataframe
The text was updated successfully, but these errors were encountered:
What needs to happen?
We have
BatchConverterTest
inbatch.py
, which is used to test the list and numpy implementations. As moreBatchConverter
implementations are added they will need to add tests that are almost identical to this one, with a few alterations:parameterized_class
.pd.testing.assert_frame_equal
for pandas)We should make it possible to re-use the tests in
BatchConverterTest
without copy-pasting it, as this will lead to fragmentation.Issue Priority
Priority: 2
Issue Component
Component: dsl-dataframe
The text was updated successfully, but these errors were encountered: