Add option to disable validation of cloud bigtable change stream IO #31376
Conversation
Change-Id: I0ca42df2f6d8dfe9cd1eaac7208c77fa8d213c4b
Change-Id: I4b7f060381d3402a62a1e68045e1d3b7f1f50a9b
|
@jackdingilian for Bigtable review. |
There was a problem hiding this comment.
Thanks, are you able to add unit tests to test this functionality? I was thinking something mirroring how its done here, but maybe just creating a new test file under changestreams will suffice.
|
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Change-Id: I4b47693f7bdc83b116b0b3aea9cdc2cd77f15bc4
|
I added some unit tests for the ReadChangeStream config. |
...a/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
Outdated
Show resolved
Hide resolved
...a/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
Show resolved
Hide resolved
Change-Id: I8f341d36e78f5b737741afa4dfa899884b3c9387
|
@svetakvsundhar we're ready to merge. Thanks. |
|
Sounds good. Will merge after CI completes! Thanks for the quick turnaround! |
|
|
fixes #31360 Add withoutValidation option to Bigtable change stream IO.
This aligns with withoutValidation of Read and Write IO. This allows users to create a pipeline without validating the correctness of the change stream configurations. This includes validating the change stream table exists, metadata table exists, metadata table is using the correct schema, and app profile used is appropriate. This allows the users to create a pipeline without Bigtable permissions locally. Bigtable permissions is still required by the pipeline itself in order to stream the table.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.