Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the original way of validating Bigtable Change Stream table existance to improve compatibility with testing #31597

Merged

Conversation

tonytanger
Copy link
Contributor

Use the original way of validating Bigtable Change Stream table existance to improve compatibility with testing.

In #31376 I moved around validation and introduced a different way of checking the existence of the Change Stream table using BigtableServiceFactory instead of BigtableChangeStreamAccessor. BigtableChangeStreamAccessor has some customization that is not included in BigtableServiceFactory and is needed for integration testing against different environments.

Ideally, we have only one way of interfacing with Bigtable services, so we would merge BigtableServiceFactory and BigtableChangeStreamAccessor. But meanwhile, we should revert back to using BigtableChangeStreamAccessor in the ChangeStream connector.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

…ance to improve compatbility with testing

Change-Id: Iba1ee679fed4276a271f2fc83c7ad657a0da8174
@tonytanger
Copy link
Contributor Author

@jackdingilian for Bigtable review.

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @Abacn for label io.
R: @mutianf for label bigtable.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@jackdingilian
Copy link
Contributor

LGTM for bigtable

@Abacn Abacn merged commit b1c8040 into apache:master Jun 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants