Use the original way of validating Bigtable Change Stream table existance to improve compatibility with testing #31597
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the original way of validating Bigtable Change Stream table existance to improve compatibility with testing.
In #31376 I moved around validation and introduced a different way of checking the existence of the Change Stream table using BigtableServiceFactory instead of BigtableChangeStreamAccessor. BigtableChangeStreamAccessor has some customization that is not included in BigtableServiceFactory and is needed for integration testing against different environments.
Ideally, we have only one way of interfacing with Bigtable services, so we would merge BigtableServiceFactory and BigtableChangeStreamAccessor. But meanwhile, we should revert back to using BigtableChangeStreamAccessor in the ChangeStream connector.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.