[BEAM-8645] A test case for TimestampCombiner. #10081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuangLED
changed the title
|
R: @robertwb |
|
Run Portable_Python PreCommit |
3 tasks
|
Hi, Robert, |
robertwb
reviewed
Nov 19, 2019
|
Pulled from master, and retried. The EARLIEST case still failed, with error: "apache_beam.runners.direct.executor: WARNING: A task failed with exception: Failed assert: [(('k', 500), Timestamp(7))] not in [(('k', 500), Timestamp(2))] [while running 'assert per window/Match']" |
|
would you please point out which PR in the master Might resolve the issue? I can follow and trace that part a bit using this test case. |
robertwb
reviewed
Nov 21, 2019
|
Updated. |
3 tasks
robertwb
approved these changes
Nov 21, 2019
| result = (p | ||
| | TestStream() | ||
| .add_elements([window.TimestampedValue(('k', 100), 2)]) | ||
| .add_elements([window.TimestampedValue(('k', 400), 7)]) |
There was a problem hiding this comment.
Turns out this happens to work because 7 is the last element.
|
Run Portable_Python PreCommit |
|
Thanks for applying the unskip test. All test now passed. This PR is ready to be merged. |
|
@robertwb ping for merging this PR |
11moon11
pushed a commit
to 11moon11/beam
that referenced
this pull request
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds test case for TimestampCombiner.
Skip tag is added (until BEAM-8657 and BEAM-8645 are resolved)
Related mailing list dicussions: https://lists.apache.org/thread.html/d3af1f2f84a2e59a747196039eae77812b78a991f0f293c717e5f4e1@%3Cdev.beam.apache.org%3E
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.