Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-8645] Create a py test case for Re-iteration on GBK result. #10135

Merged
merged 2 commits into from Nov 19, 2019
Merged

[BEAM-8645] Create a py test case for Re-iteration on GBK result. #10135

merged 2 commits into from Nov 19, 2019

Conversation

HuangLED
Copy link
Contributor

Create a python test case to iterate on GBK result for multiple times.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • [ X] Choose reviewer(s) and mention them in a comment (R: @username).
  • [ X] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status		 --- Build Status
Build Status		 Build Status
Build Status		 --- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status		 Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@HuangLED
Copy link
Contributor Author

HuangLED commented Nov 16, 2019 •
edited

R: @robertwb , @pabloem

Thanks.

robertwb
robertwb reviewed Nov 18, 2019
View reviewed changes
Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just some minor comments.

sdks/python/apache_beam/transforms/ptransform_test.py Outdated Show resolved Hide resolved
sdks/python/apache_beam/transforms/ptransform_test.py Outdated Show resolved Hide resolved
@HuangLED
Copy link
Contributor Author

Thanks for reviewing.

Updated.

@robertwb robertwb merged commit 7828147 into apache:master Nov 19, 2019
11moon11 pushed a commit to 11moon11/beam that referenced this pull request Nov 20, 2019
@HuangLED @11moon11
[BEAM-8645] Create a py test case for Re-iteration on GBK result. (ap…
7a1aace 
…ache#10135)
11moon11 pushed a commit to 11moon11/beam that referenced this pull request Dec 12, 2019
@HuangLED @11moon11
[BEAM-8645] Create a py test case for Re-iteration on GBK result. (ap…
f07de9a 
…ache#10135)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertwb robertwb robertwb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HuangLED @robertwb