[BEAM-3419] Flesh out iterable side inputs and key enumeration for multimaps in shared libraries #10147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukecwik
force-pushed
the
side_input
branch
2 times, most recently
from
d319089
to
38cc4bc
Compare
…ltimaps in shared libraries This now removed the byte[] that was used as the key and exposed the SDKs coder specifically using the structural value for comparison. Update portable Python to use the iterable state key. Note that this doesn't effect Dataflow since dataflow_runner.py converts all iterable side inputs into multimap right now and no SDK performs key enumeration yet. Update both Flink and Spark to support iterable API and also key enumeration for multimaps. To minimize the extent of this change, I did the minimal modification for Dataflow. A follow-up PR will do the same for Dataflow and then enable multimap side input key enumeration and iterable lookup within various SDKs.
lukecwik
changed the title
|
Run Portable_Python PreCommit |
|
Run Python PreCommit |
|
Run Java PreCommit |
mxm
reviewed
Nov 20, 2019
|
Run Flink ValidatesRunner |
|
I think this breaks :runners:spark:compileJava on master. @lukecwik can you please take a look? |
|
|
@ibzib has a fix in flight for this. |
11moon11
pushed a commit
to 11moon11/beam
that referenced
this pull request
Dec 12, 2019
…ltimaps in shared libraries (apache#10147) This now removed the byte[] that was used as the key and exposed the SDKs coder specifically using the structural value for comparison. Update portable Python to use the iterable state key. Note that this doesn't effect Dataflow since dataflow_runner.py converts all iterable side inputs into multimap right now and no SDK performs key enumeration yet. Update both Flink and Spark to support iterable API and also key enumeration for multimaps. To minimize the extent of this change, I did the minimal modification for Dataflow. A follow-up PR will do the same for Dataflow and then enable multimap side input key enumeration and iterable lookup within various SDKs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now removed the byte[] that was used as the key and exposed the SDKs coder specifically using the structural value for comparison.
Update portable Python to use the iterable state key. Note that this doesn't effect Dataflow since dataflow_runner.py converts all iterable side inputs into multimap right now and no SDK performs key enumeration yet.
Update both Flink and Spark to support iterable API and also key enumeration for multimaps. To minimize the extent of this change, I did the minimal modification for Dataflow. A follow-up PR will do the same for Dataflow and then enable multimap side input key enumeration and iterable lookup within various SDKs.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.