[BEAM-7594] Fix flaky filename generation #10194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @pabloem |
|
CC: @tvalentyn |
pabloem
reviewed
Nov 22, 2019
| @@ -101,17 +100,19 @@ def write_data( | |||
| return f.name, [line.decode('utf-8') for line in all_data] | |||
|
|
|||
|
|
|||
| def write_pattern(lines_per_file, no_data=False): | |||
| def write_pattern(lines_per_file, no_data=False, return_filenames=False): | |||
There was a problem hiding this comment.
It might be nice to change all of the uses of the function, instead of conditionally changing the return type. But I won't block the PR on this : ) LGTM
There was a problem hiding this comment.
I don't believe any of the other tests care about the filenames.
|
LGTM except for the one comment. |
|
Run Python PreCommit |
2 similar comments
|
Run Python PreCommit |
|
Run Python PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See this comment for description of flake.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.