Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-2.18.0][BEAM-8861] Disallow self-signed certificates by default in ElasticsearchIO #10353

Merged
merged 1 commit into from Dec 13, 2019

Conversation

iemejia
Copy link
Member

@iemejia iemejia commented Dec 11, 2019

Same that the one I accidentally push forced to cherry pick another issue.
R: @udim
CC: @coheigea

@iemejia iemejia requested a review from udim December 11, 2019 14:48
@iemejia iemejia changed the title BEAM-8861 - Disallow self-signed certs by default [release-2.18.0][BEAM-8861] Disallow self-signed certificates by default in ElasticsearchIO Dec 11, 2019
@iemejia
Copy link
Member Author

iemejia commented Dec 12, 2019

For info we had to backport this into 2.17.0 too and it was already merged in #10354

Copy link
Member

@udim udim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, wordcount in preCommitLegacyWorker is expected to fail inrelease branch.

@udim udim merged commit e657f18 into apache:release-2.18.0 Dec 13, 2019
@iemejia iemejia deleted the release-2.18.0-BEAM-8861 branch December 17, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants