New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please review [https://github.com/apache/beam/pull/10383] instead. #10374
Closed
bumblebee-coming
wants to merge
10
commits into
apache:master
from
bumblebee-coming:fixed_windows_combine
Closed
Please review [https://github.com/apache/beam/pull/10383] instead. #10374
bumblebee-coming
wants to merge
10
commits into
apache:master
from
bumblebee-coming:fixed_windows_combine
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R: @chamikaramj |
Run Python PreCommit |
Old version was unhelpful and pretty misleading, this should be way better if we run into this again in the future.
Don't review this PR. It's polluted. Please review #10383 instead. |
bumblebee-coming
changed the title
[BEAM-8575] Added a unit test to test that Combine works with FixedWi…
Please review [https://github.com/apache/beam/pull/10383] instead.
Dec 13, 2019
Closing this, the other referenced PR (#10383) is merged already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ndows.
Please review [https://github.com//pull/10383] instead.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.