[BEAM-5600] Add unimplemented split API to Runner side SDF libraries. #10482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukecwik
commented
Dec 30, 2019
| for (CloseableFnDataReceiver<?> inputReceiver : inputReceivers.values()) { | ||
| @Override | ||
| public void split(double fractionOfRemainder) { | ||
| throw new UnsupportedOperationException("Support splitting, TODO: BEAM-5600"); |
There was a problem hiding this comment.
I need access to the control service which is why I made the ActiveBundle a nested class.
lukecwik
force-pushed
the
splittabledofn6
branch
from
b917619
to
c126346
Compare
|
Run Java PreCommit |
|
Run Portable_Python PreCommit |
|
Run Python2_PVR_Flink PreCommit |
|
Run Java PreCommit |
2 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
This creates an unsupported API to the RemoteBundle and a default split handler that throws.
lukecwik
force-pushed
the
splittabledofn6
branch
from
c126346
to
d6c0ab2
Compare
boyuanzz
reviewed
Jan 2, 2020
...fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/SdkHarnessClient.java
Show resolved
Hide resolved
boyuanzz
approved these changes
Jan 2, 2020
|
Thanks! LGTM. |
vmarquez
pushed a commit
to vmarquez/beam
that referenced
this pull request
Apr 1, 2020
…apache#10482) * [BEAM-5600] Add unimplemented split API to Runner side SDF libraries. This creates an unsupported API to the RemoteBundle and a default split handler that throws.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a split call that forwards the values to the SDK and a default split handler that throws.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.