Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-9040] Add Spark Structured Streaming to Nexmark PostCommit run #10485

Closed
wants to merge 3 commits into from
Closed

[BEAM-9040] Add Spark Structured Streaming to Nexmark PostCommit run #10485

wants to merge 3 commits into from

Conversation

iemejia
Copy link
Member

@iemejia iemejia commented Dec 31, 2019 •
edited

@iemejia iemejia force-pushed the BEAM-9040-ss-runner-postcommit branch from 2dfe79b to 83d90d9 Compare December 31, 2019 08:20
@iemejia iemejia force-pushed the BEAM-9040-ss-runner-postcommit branch 4 times, most recently from 615c258 to 3efef33 Compare January 1, 2020 11:41
@iemejia iemejia force-pushed the BEAM-9040-ss-runner-postcommit branch from 3efef33 to b504160 Compare January 1, 2020 14:01
@iemejia
Copy link
Member Author

iemejia commented Jan 1, 2020

Run Seed Job

@iemejia
Copy link
Member Author

iemejia commented Jan 1, 2020

Run Spark Runner Nexmark Tests

echauchot
echauchot approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@echauchot echauchot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that Ismael ! Good to see nexmark running automatically for this new runner. LGTM . regarding the history, I think nexmark changes and jenkins changes need to be isolated in different commits. But I would squash the 2 nexmark commits together because they need each other and because they form a coherent change.

iemejia added a commit that referenced this pull request Jan 14, 2020
@iemejia
Merge pull request #10485: [BEAM-9040] Add Spark Structured Streaming…
7bea94c 
… to Nexmark PostCommit run
@iemejia
Copy link
Member Author

iemejia commented Jan 14, 2020

Thanks, merged manually to squash the suggested commits.

@iemejia iemejia closed this Jan 14, 2020
@iemejia iemejia deleted the BEAM-9040-ss-runner-postcommit branch January 14, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echauchot echauchot echauchot approved these changes

@aromanenko-dev aromanenko-dev Awaiting requested review from aromanenko-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iemejia @echauchot