[BEAM-9059] Migrate PTransformTranslation to use string constants #10511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @sunjincheng121 can you review this change for me? |
|
Run Java PreCommit |
|
@lukecwik sure. I would like to have look at this changes. |
There was a problem hiding this comment.
The PR LGTM.
One minor thing is that it would be better if we can reuse the contants defined in PTransformTranslation, such as CreateExecutableStageNodeFunction, etc.
What do you think?
| "beam:transform:sdf_process_sized_element_and_restrictions:v1"; | ||
|
|
||
| static { | ||
| checkState(PAR_DO_TRANSFORM_URN.equals(getUrn(StandardPTransforms.Primitives.PAR_DO))); |
There was a problem hiding this comment.
Add comment: // Primitives ？(same as line 67)
There was a problem hiding this comment.
I'll include that in a followup PR where I change many of the existing getUrn calls as you suggest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for us to use them in switch/case statements
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.