Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8780]Improve docker container release script #10512

Merged
merged 1 commit into from Jan 7, 2020

Conversation

Hannah-Jiang
Copy link
Contributor

Improve docker container script: reuse verified rc images instead of recreating images.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@Hannah-Jiang Hannah-Jiang changed the title [WIP][BEAM-8780]Improve container release script [BEAM-8780]Improve docker container release script Jan 7, 2020
@Hannah-Jiang
Copy link
Contributor Author

R: @markflyhigh
Cc: @kyle-winkelman do we need to do the same thing for Flink images?
Cc: @Ardagan

Copy link
Contributor

@Ardagan Ardagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.
There's also a way to do this without pulling image. See https://issues.apache.org/jira/browse/BEAM-8780
Would be great if we can utilize that one.

@Hannah-Jiang
Copy link
Contributor Author

LGTM overall.
There's also a way to do this without pulling image. See https://issues.apache.org/jira/browse/BEAM-8780
Would be great if we can utilize that one.

Thanks for reviewing it.
I investigate both options mentioned at BEAM-8780. The option with updating manifest is not recommended to use in production. (https://docs.docker.com/engine/reference/commandline/manifest/). The second option with docker build creates new images, so that is not an option here.

After all, I think pull, tag and push process is the most stable and easy to understand for now.

@Hannah-Jiang
Copy link
Contributor Author

The PR is ready to be merged to master.

@Ardagan Ardagan merged commit e460f27 into apache:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants