[BEAM-9084] cleaning up docker image tag #10557
Conversation
| @@ -49,11 +49,16 @@ public String getName() { | |||
| return getProperties().get("name"); | |||
| } | |||
|
|
|||
| /** Provides the SDK version. */ | |||
| /** Provides the BEAM version. */ | |||
There was a problem hiding this comment.
It might be good to provide examples here to explain the difference.
There was a problem hiding this comment.
good idea, added it.
Hannah-Jiang
force-pushed
the
cleaning_up_docker_tags
branch
from
9b4ee26
to
2babd75
Compare
|
retest this please |
|
Run CommunityMetrics PreCommit |
|
CommunityMetrics failure was due to https://issues.apache.org/jira/browse/BEAM-8409 (which apparently afflicts only node 15) @Hannah-Jiang please fix Spotless |
Fixed spotless, can we re-trigger the test please? |
|
retest this please |
1 similar comment
|
retest this please |
|
retest this please |
|
@Hannah-Jiang looks like version got bumped for 2.19 release, please resolve. Not sure why tests aren't running :/ |
|
Oh and of course now they show up... I must have said the magic words 😆 |
It is resolved now and all the tests are re-triggered. |
Use consistent default tags for docker images.
For released images, it is version number. (ie: 2.17.0)
For developing versions, it is version number + '.dev'. (ie: 2.17.0.dev)
R: @ibzib
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.