Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9061] Add version guards to requirements file for integration tests. #10568

Merged
merged 1 commit into from Jan 16, 2020

Conversation

tvalentyn
Copy link
Contributor


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@tvalentyn
Copy link
Contributor Author

r: @udim

@tvalentyn
Copy link
Contributor Author

Run Python 2 PostCommit

@@ -194,8 +194,10 @@ if [[ -z $PIPELINE_OPTS ]]; then
fi

# Install test dependencies for ValidatesRunner tests.
echo "pyhamcrest" > postcommit_requirements.txt
echo "mock" >> postcommit_requirements.txt
# pyhamcrest==1.10.0 doesn't work on Py2.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like adding yet another location with version numbers. I wish we a single SoT for versioning.

@udim
Copy link
Member

udim commented Jan 15, 2020

Opened https://issues.apache.org/jira/browse/BEAM-9127 for postcommit py2:crossLanguagePortableWordCount failure.
Have not tracked down root cause for py2:hdfsIntegrationTest yet.

@tvalentyn
Copy link
Contributor Author

Thanks, @udim. Opened https://issues.apache.org/jira/browse/BEAM-9130 for HDFS failure.

@tvalentyn
Copy link
Contributor Author

Also checked that we now use pyhamcrest==1.10.1 on DF workers.

I 2020-01-15T18:01:18.297051Z Executing: /usr/local/bin/pip install -r /var/opt/google/dataflow/requirements.txt --no-index --no-deps --find-links /var/opt/google/dataflow 
I 2020-01-15T18:01:18.465683Z   Building wheel for pyhamcrest (setup.py): finished with status 'done' 
I 2020-01-15T18:01:18.466534Z   Created wheel for pyhamcrest: filename=PyHamcrest-1.10.1-cp27-none-any.whl size=48899 sha256=7123cf4cce0b8b917bf7dd1f286a4c051bf090f70347b1495243edf888eaa03a 
I 2020-01-15T18:01:18.466742Z   Stored in directory: /root/.cache/pip/wheels/7c/ea/7d/664d2b28854ea324717ed693c92c042db5b478b67962637a38 

@aaltay
Copy link
Member

aaltay commented Jan 18, 2020

Does pyhamcrest > 1.10.0 work with python 2?

@tvalentyn
Copy link
Contributor Author

1.10.1 does, 2.0.0 does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants