New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9061] Add version guards to requirements file for integration tests. #10568
Conversation
r: @udim |
Run Python 2 PostCommit |
@@ -194,8 +194,10 @@ if [[ -z $PIPELINE_OPTS ]]; then | |||
fi | |||
|
|||
# Install test dependencies for ValidatesRunner tests. | |||
echo "pyhamcrest" > postcommit_requirements.txt | |||
echo "mock" >> postcommit_requirements.txt | |||
# pyhamcrest==1.10.0 doesn't work on Py2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like adding yet another location with version numbers. I wish we a single SoT for versioning.
Opened https://issues.apache.org/jira/browse/BEAM-9127 for postcommit py2:crossLanguagePortableWordCount failure. |
Thanks, @udim. Opened https://issues.apache.org/jira/browse/BEAM-9130 for HDFS failure. |
Also checked that we now use pyhamcrest==1.10.1 on DF workers.
|
Does pyhamcrest > 1.10.0 work with python 2? |
1.10.1 does, 2.0.0 does not. |
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.