[BEAM-4150] Remove fallback case for coder not specified within RemoteGrpcPort. #10755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoteGrpcPort. Update the JRH in Dataflow to specify the coder id on the RemoteGrpcPort. All runners now specify the coder id so we can remove the fallback case.
|
Tested JRH change internally within Google as well. |
|
Run Python PreCommit |
|
Run Go Postcommit |
lostluck
requested changes
Feb 4, 2020
| @@ -64,6 +64,13 @@ func UnmarshalPlan(desc *fnpb.ProcessBundleDescriptor) (*Plan, error) { | |||
| } | |||
|
|
|||
| u := &DataSource{UID: b.idgen.New()} | |||
| u.Coder, err = b.coders.Coder(cid) // Expected to be windowed coder | |||
There was a problem hiding this comment.
Please run gofmt on your code. Go uses Tabs for indentation, not spaces.
|
Run Python2_PVR_Flink PreCommit |
|
Run Java PreCommit |
|
Tthey always have one.
…On Tue, Feb 4, 2020 at 11:04 AM Robert Burke ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In sdks/go/pkg/beam/core/runtime/exec/translate.go
<#10755 (comment)>:
> @@ -64,6 +64,13 @@ func UnmarshalPlan(desc *fnpb.ProcessBundleDescriptor) (*Plan, error) {
}
u := &DataSource{UID: b.idgen.New()}
+ u.Coder, err = b.coders.Coder(cid) // Expected to be windowed coder
+ if err != nil {
+ return nil, err
+ }
+ if !coder.IsW(u.Coder) {
+ return nil, errors.Errorf("unwindowed coder %v on DataSource %v: %v", cid, id, u.Coder)
+ }
for key, pid := range transform.GetOutputs() {
Do GRPC datasources always only have a single output?
I note that we aren't using the pid, in the new code.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10755?email_source=notifications&email_token=ACM4V3D4ENJGCCU7DCMAVXLRBG333A5CNFSM4KPKV7XKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUG4ZCI#pullrequestreview-353225865>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACM4V3AXN6VNEWJK3UURZZ3RBG333ANCNFSM4KPKV7XA>
.
|
|
Whoops. Dead comment I thought I deleted after answering my own question
after expanding how much code was revealed.
…On Tue, Feb 4, 2020, 1:20 PM Lukasz Cwik ***@***.***> wrote:
Tthey always have one.
On Tue, Feb 4, 2020 at 11:04 AM Robert Burke ***@***.***>
wrote:
> ***@***.**** commented on this pull request.
> ------------------------------
>
> In sdks/go/pkg/beam/core/runtime/exec/translate.go
> <#10755 (comment)>:
>
> > @@ -64,6 +64,13 @@ func UnmarshalPlan(desc
*fnpb.ProcessBundleDescriptor) (*Plan, error) {
> }
>
> u := &DataSource{UID: b.idgen.New()}
> + u.Coder, err = b.coders.Coder(cid) // Expected to be windowed coder
> + if err != nil {
> + return nil, err
> + }
> + if !coder.IsW(u.Coder) {
> + return nil, errors.Errorf("unwindowed coder %v on DataSource %v: %v",
cid, id, u.Coder)
> + }
>
> for key, pid := range transform.GetOutputs() {
>
> Do GRPC datasources always only have a single output?
>
> I note that we aren't using the pid, in the new code.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <
#10755?email_source=notifications&email_token=ACM4V3D4ENJGCCU7DCMAVXLRBG333A5CNFSM4KPKV7XKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCUG4ZCI#pullrequestreview-353225865
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/ACM4V3AXN6VNEWJK3UURZZ3RBG333ANCNFSM4KPKV7XA
>
> .
>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10755?email_source=notifications&email_token=ADKDOFKM6KGP2G7D7HTUARLRBHLZ5A5CNFSM4KPKV7XKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKZHI4I#issuecomment-582120561>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKDOFIPMLRNDWOLYIXBSOLRBHLZ5ANCNFSM4KPKV7XA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All runners now specify the coder id.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.