-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-7198] rename ToStringCoder to ToBytesCoder for proper representation of its role #10828
Conversation
…ation of its role
R: @tvalentyn |
test test test |
Changes LGTM, we can merge once tests pass. Thanks a lot, @lazylynx ! |
@tvalentyn PTAL |
test test test |
hmm... Looks like Jenkins is not listening this time. |
Run PythonFormatter PreCommit |
Yep, not listening :( |
test test test? |
Run PythonFormatter PreCommit |
Run Python PreCommit |
retest this please |
Run Python PreCommit |
Run PythonLint PreCommit |
retest this please |
Run PythonLint PreCommit |
1 similar comment
Run PythonLint PreCommit |
Thanks, @lazylynx! |
Oops, I forgot to squash commits before the merge. Oh well. |
Renamed
ToStringCoder
toToBytesCoder
andToStringCoder
is remained as an alias toToBytesCoder
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.