New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9301] Check in beam-linkage-check.sh #10841
Conversation
@@ -0,0 +1,99 @@ | |||
#!/bin/bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iemejia I tried with zsh compatible shell script, but it's not trivial. Therefore this relies on bash.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues, the shebang should cover it so ok for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Nice!
Thanks it will be really useful to have this here so we can evolve it together if needed. |
Oups first suggestion of improvement detect if master is checked eagerly to not waste time before failing |
What is it? |
In the last part of the script we do |
Thank you for explanation. |
#10769 (comment)
This is a script to compare linkage errors (checkJavaLinkage task in the root gradle project) between PR's branch and master branch.
This is a temporary solution before Linkage Checker implements exclusion rules (BEAM-9206).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.