[BEAM-8965] Remove duplicate sideinputs in ConsumerTrackingPipelineVisitor #10901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Python Postcommit |
|
Thanks! I'll take a look : ) |
|
Run Python Postcommit |
|
Run Python 3.5 Postcommit |
pabloem
reviewed
Feb 25, 2020
| self.views.append(side_input) | ||
| if side_input not in self._side_input_views: | ||
| self._side_input_views[side_input] = side_input | ||
| self.views = [ |
There was a problem hiding this comment.
Here we may want to only append rather than rebuild all of self.views?
An idea is that we may want to keep self._views = set(), add views to the set, and add a @property that returns the set as a list? (no need to implement this way, but we do want to make sure that we are not dropping elements from 'views' that we appended in previous visit_transform calls
|
Run Python PreCommit |
|
Retest this please |
|
retest this please |
|
thanks @bobingm ! Looks good to me. Can you fix the formatting issues, and I'll merge? |
pabloem
approved these changes
Feb 26, 2020
|
@pabloem the failure is not caused by this PR. |
|
I see. Thanks for pointing that out. |
|
thanks @bobingm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is mainly preventing
BundleBasedDirectRunnerevaluates single side_input more than once.To achieve this, this PR changes the logic to get side_input views in
ConsumerTrackingPipelineVisitor, and modify the unit tests to make sure that when one single side_input is used in two different PTransforms, it will be evaluated once.Check List
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.