[BEAM-9344] Add support for bundle finalization execution to the Beam Java SDK. #10910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
lukecwik
force-pushed
the
bundlefinalization
branch
from
52bc261
to
ff52f0f
Compare
probot-autolabeler
bot
added
apex
build
dataflow
direct
flink
gearpump
jet
portability
samza
spark
labels
lukecwik
changed the title
|
This is needed for the unbounded source wrapper to be able to get an initial version working without watermark reporting. |
lukecwik
force-pushed
the
bundlefinalization
branch
from
ff52f0f
to
a5bf78f
Compare
|
Run Java PreCommit |
Ardagan
approved these changes
Feb 21, 2020
| import org.apache.beam.sdk.transforms.splittabledofn.RestrictionTracker; | ||
| import org.apache.beam.sdk.transforms.splittabledofn.SplitResult; |
There was a problem hiding this comment.
At <a href="https://s.apache.org/splittable-do-fn>, second quote is missing that breaks all formatting in github and should break href. Can you fix typo please?
This change adds support for passing in the BundleFinalizer as an input parameter to start/process/finish and wires it through within the SDK harness. The only supported combination that can execute this is Python ULR and Dataflow using UW which is why all the validates runner test configurations have added the test category to the exclusions list.
lukecwik
force-pushed
the
bundlefinalization
branch
from
a5bf78f
to
fa5f428
Compare
…actory context parameter call.
…el for BundleFinalizer
|
Run Java PreCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.