[BEAM-9424] Allow grouping by LogicalType #11015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @kanterov |
kanterov
reviewed
Mar 3, 2020
| @Test | ||
| public void testLogicalTypes() { | ||
| Schema beamSchemaWithLogicalTypes = | ||
| BigQueryUtils.fromTableSchema( |
There was a problem hiding this comment.
Is it possible to use DummySqlTimeType and DummySqlDateType as in other tests? I find dependency on gcp-io not necessary
fediazgon
force-pushed
the
9424-logicalTypes-groupBy
branch
2 times, most recently
from
8041197
to
73576ac
Compare
fediazgon
force-pushed
the
9424-logicalTypes-groupBy
branch
from
73576ac
to
f8c4b56
Compare
|
Run Java PreCommit |
|
Jenkins doesn't build |
kanterov
approved these changes
Mar 3, 2020
|
Run Java PreCommit |
|
Run SQL PostCommit |
|
retest this please |
1 similar comment
|
retest this please |
|
LGTM |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GROUP BYstatement fails if field isLogicalType. E.g., when converting a BQ schema with eitherTIME,DATEorDATETIMEto a Beam schema and grouping by one or more of these fields.This PR add supports for grouping by LogicalType.
This fixes https://issues.apache.org/jira/browse/BEAM-9424.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.