[BEAM-9415] fix postcommit xvr tests #11018
Merged
+22
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @chamikaramj |
|
Could you add more details about the breakage and the fix to the PR description and JIRA ? (since we are updating External.java here). |
|
Updated. |
chamikaramj
reviewed
Mar 2, 2020
| @@ -28,7 +28,7 @@ dependencies { | |||
| compile project(path: ":runners:core-construction-java") | |||
| compile project(path: ":sdks:java:io:parquet") | |||
| compile project(path: ":sdks:java:core", configuration: "shadow") | |||
| provided library.java.hadoop_client | |||
| testRuntime library.java.hadoop_client | |||
There was a problem hiding this comment.
Is this change related ?
There was a problem hiding this comment.
Yes. test expansion service jar is also used for SDK container dependency. hadoop client library should be included in the shadow jar.
|
Run Python PreCommit |
|
python precommit failure looks irrelevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks whether the coder is compatible with Java SDK before rehydrating it from expanded components. The coder id renaming is only needed for Java SDK compatible coders so the change is safe.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.