Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9288] Not bundle conscrypt in gRPC vendor in META-INF #11049

Merged
merged 1 commit into from Mar 5, 2020

Conversation

amaliujia
Copy link
Contributor

R: @lukecwik @sunjincheng121


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@amaliujia
Copy link
Contributor Author

Tested by running

jar tvf vendor/grpc-1_26_0/build/libs/beam-vendor-grpc-1_26_0-0.3.jar | grep conscrypt

@amaliujia amaliujia changed the title [BEAM-9288] Not bundle conscrypt in gRPC vendor in META-INF/ [BEAM-9288] Not bundle conscrypt in gRPC vendor in META-INF Mar 4, 2020
@amaliujia
Copy link
Contributor Author

This PR further excludes conscrypt from vendored grpc jar, which is a subsequent work of #10940

@amaliujia
Copy link
Contributor Author

Run CommunityMetrics PreCommit

@amaliujia
Copy link
Contributor Author

Run Python PreCommit

@amaliujia
Copy link
Contributor Author

@lukecwik all green. Please feel free to merge this PR and start vendored gRPC release.

@lukecwik lukecwik merged commit 28d05d3 into apache:master Mar 5, 2020
@amaliujia amaliujia deleted the rw-exclude_form_vendoring branch March 5, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants