Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-9477] RowCoder should be hashable and picklable #11088

Merged
merged 4 commits into from Mar 13, 2020
Merged

[BEAM-9477] RowCoder should be hashable and picklable #11088

merged 4 commits into from Mar 13, 2020

Conversation

TheNeuralBit
Copy link
Member

Defines __hash__ and __reduce__ for RowCoder. Also adds some (previously failing) tests of these functions.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status		 Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status		 --- Build Status
Build Status
Build Status		 Build Status
Build Status		 --- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status		 Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@TheNeuralBit
Copy link
Member Author

R: @udim are you a good person to review this?

@TheNeuralBit TheNeuralBit requested a review from udim March 11, 2020 20:02
@TheNeuralBit TheNeuralBit mentioned this pull request Mar 11, 2020
Merged
udim
udim approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@udim udim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@TheNeuralBit TheNeuralBit merged commit 33ec0bb into apache:master Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@udim udim udim approved these changes

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TheNeuralBit @udim