[BEAM-9503] Insert missing comma in process worker script. #11123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Python2 Postcommit |
|
Run Python3 Postcommit |
|
Run Python Postcommit |
|
@ibzib do you know what is the relevant postcommit? Could we run those as well? |
This bug has been around for a while, so apparently this code branch is not being tested. We will have to follow up and investigate why. |
|
LGTM |
|
Run Python 2 PostCommit |
|
Run Python 3.5 PostCommit |
|
Run Python 3.6 PostCommit |
|
Run Python 3.7 PostCommit |
Closed
4 tasks
|
Python 3.5 and 3.7 postcommits flaked because of BEAM-8866 |
|
Run Python 3.5 PostCommit |
|
Run Python 3.7 PostCommit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amaliujia I'm not sure why this bug hasn't been caught before, but this whole code path is broken and it's going to block TFX-on-Flink, so I request a cherry-pick for this PR.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.