New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9510] Fixing version incompatibilities in base_image_requirements.txt #11142
Conversation
R: @aaltay |
Run Dataflow Python ValidatesContainer |
Run Python Dataflow ValidatesContainer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you!
Thanks, @davidyan74! Added a small change to reflect that |
Run Python Dataflow ValidatesContainer |
LGTM
|
While Jenkins does not show test result on the PR, the tests are actually running: https://builds.apache.org/job/beam_PostCommit_Py_ValCont_PR/122/. |
Run Python Dataflow ValidatesContainer |
Test logs LGTM: https://builds.apache.org/job/beam_PostCommit_Py_ValCont_PR/123/timestamps/?time=HH:mm:ss&timeZone=GMT-7&appendLog&locale=en_US FYI @amaliujia - containers on the latest release branch may also be broken and require changes to fix incompatible dependencies. Do you think you can check this? Otherwise it may come up during release validation. You can make a similar change to the release branch, then have a look at the logs of ValidatesContainer suite against the release branch, and make sure pip does not complain about incompatible dependencies. @Hannah-Jiang and @davidyan74 also can help if you have questions. |
Thanks @tvalentyn. We might want to add |
Fiiled BEAM-9530. |
Tried this out and it doesn't have any compatibility error messages any more for python3.
R: @tvalentyn
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.