Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9430] Update CHANGES.md to reflect removal of ProcessContext#updateWatermark #11178

Merged
merged 1 commit into from Mar 20, 2020

Conversation

lukecwik
Copy link
Member


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@lukecwik
Copy link
Member Author

R: @mxm

Follow up for #10992

Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iemejia iemejia merged commit e91659f into apache:master Mar 20, 2020
@iemejia
Copy link
Member

iemejia commented Mar 20, 2020

I am not sure if this means now that we can resolve the issue. Please do it yourself if it is the case @lukecwik

@@ -58,6 +58,7 @@
## Breaking Changes

* HBaseIO.ReadAll now requires a PCollection of HBaseIO.Read objects instead of HBaseQuery objects ([BEAM-9279](https://issues.apache.org/jira/browse/BEAM-9279)).
* ProcessContext.updateWatermark has been removed in favor of using a WatermarkEstimator ([BEAM-9430](https://issues.apache.org/jira/browse/BEAM-9430)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we plan to add some end-user documentation for WatermarkEstimators or SDF in general?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there should be some examples of how to write SDFs added to our docs.
After Java SDFs have a way to report progress and backlog, then we should be able to do this in Python and Java (and mention that Go is in the works).

Are the docs something you were interested in doing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interested yes but unfortunately won't have time to work on that at the moment.

@mxm
Copy link
Contributor

mxm commented Mar 20, 2020

Thanks @lukecwik.

@iemejia Why the quick merge if a review was still pending on me?

@iemejia
Copy link
Member

iemejia commented Mar 20, 2020

Oh sorry it was just obviously good so I proceeded. Next time I will wait.

@mxm
Copy link
Contributor

mxm commented Mar 20, 2020

If there was nobody assigned I think that would have been fair, but given that less than a day had passed and a review was explicitly requested, I think it is better to wait. There is no need to rush such things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants