Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9500] [WIP] Refactor load tests #11181

Closed
wants to merge 1 commit into from

Conversation

pjotrekk
Copy link

@pjotrekk pjotrekk commented Mar 20, 2020

Changed the input to be initialized in the base class instead of the subclasses.

Minor:

  • Replaced creating new TimeMonitors with the one from the superclass
  • Added type to List at LoadTest:104
  • Moved initializing ByteMonitor object to constructor instead of creating it ad hoc

related: #10949


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@pjotrekk
Copy link
Author

@mwalenia

@pjotrekk
Copy link
Author

I think there is a lot more to do with the part "make LoadTest parameterized instead of a base class."

@pjotrekk pjotrekk changed the title [BEAM-9500] Refactor load tests [BEAM-9500] [WIP] Refactor load tests Mar 20, 2020
@stale
Copy link

stale bot commented May 19, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label May 19, 2020
@aaltay
Copy link
Member

aaltay commented May 28, 2020

@piotr-szuberski - what is the next step for this PR? Is it still active? Should we close it?

@stale stale bot removed the stale label May 28, 2020
@stale
Copy link

stale bot commented Jul 27, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Jul 27, 2020
@pjotrekk
Copy link
Author

pjotrekk commented Aug 4, 2020

@piotr-szuberski - what is the next step for this PR? Is it still active? Should we close it?

Sorry for such delay, I totally forgot to response. I'll close this PR as it's not that important and far outdated.

@pjotrekk pjotrekk closed this Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants