-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge pull request #11245 - Update the range for pyarrow to support new pyarrow version 0.16.0 #11251
Conversation
Update the range for pyarrow
Thanks @aaltay - To add some context and to clarify a bit on the severity of the issue: pyarrow 0.16 contains new features and bug fixes that we (TFX) care about (just to list a few: apache/arrow#6066 Note that this is not to say if this PR is not merged, any bad consequence will happen, because we can also decide to not start using pyarrow 0.16, and still rely on / add workarounds on our end. it's just more technical debt. |
Python pre commit failed with an unrelated error: 11:24:10 > Failed to list versions for com.google.errorprone:error_prone_core. |
Run Python PreCommit |
LGTM. Will merge this PR after tests finish. |
I believe last test failed with another flake. |
Run Python PreCommit |
1 similar comment
Run Python PreCommit |
@aaltay I will take care of this PR to get it merged. |
Run Python PreCommit |
Thank you! |
Run Python PreCommit |
2 similar comments
Run Python PreCommit |
Run Python PreCommit |
I don't think the failed |
Thank you. |
Update the range for pyarrow to support new pyarrow version 0.16.0
Kind of. Latest version of pyarrow is not supported blocking a down stream users next release (TFX).
No.
Maybe. Depends on what is pre-installed in containers. We do not need to change what is pre-installed and most users would not have an issue.
TFX users. (Probably >10% user base.)
Yes, but they will need to delay their release until 2.21.0.
@amaliujia - Please review this. I am not sure if this is a clear cut case for a cherry pick, I will leave up to you to decide.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.