Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-4374] Short IDs for the Python SDK #11286

Merged
merged 5 commits into from Apr 2, 2020

Conversation

TheNeuralBit
Copy link
Member

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@TheNeuralBit
Copy link
Member Author

R: @lukecwik does this look correct?

Copy link
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the right path, could use some testing.

"""
# type: (metrics_pb2.MonitoringInfo) -> str
with self._lock:
key = monitoring_infos.to_key(monitoring_info)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed adding your monitoring_infos changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@lukecwik lukecwik Apr 2, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup and I was editing that code a week ago

sdks/python/apache_beam/runners/worker/sdk_worker.py Outdated Show resolved Hide resolved
TheNeuralBit and others added 2 commits April 2, 2020 09:58
@lukecwik
Copy link
Member

lukecwik commented Apr 2, 2020

Linter complains:

10:03:16 ************* Module apache_beam.runners.portability.fn_api_runner.worker_handlers
10:03:16 apache_beam/runners/portability/fn_api_runner/worker_handlers.py:62:0: E0001: Cannot import 'apache_beam.runners.worker.sdk_worker' due to syntax error 'misplaced type annotation (<unknown>, line 95)' (syntax-error)
10:03:16 ************* Module apache_beam.runners.worker.sdk_worker
10:03:16 apache_beam/runners/worker/sdk_worker.py:95:47: E0001: misplaced type annotation (<unknown>, line 95) (syntax-error)
10:03:16 ************* Module apache_beam.runners.worker.sdk_worker_main
10:03:16 apache_beam/runners/worker/sdk_worker_main.py:43:0: E0001: Cannot import 'apache_beam.runners.worker.sdk_worker' due to syntax error 'misplaced type annotation (<unknown>, line 95)' (syntax-error)

@TheNeuralBit TheNeuralBit merged commit 6ce1942 into apache:master Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants