[BEAM-9562] Update Element.timer and Element.Timer to Element.timers and Element.Timers #11373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please regenerate the go protos |
lukecwik
reviewed
Apr 10, 2020
| @@ -516,7 +516,7 @@ message Elements { | |||
| repeated Data data = 1; | |||
|
|
|||
| // (Optional) A list of timer byte streams. | |||
| repeated Timer timer = 2; | |||
| repeated Timer timers = 2; | |||
There was a problem hiding this comment.
@robertwb did you want to rename this field or the proto message Timer -> Timers or both?
boyuanzz
changed the title
robertwb
approved these changes
Apr 10, 2020
lukecwik
approved these changes
Apr 10, 2020
boyuanzz
commented
Apr 10, 2020
| @@ -6242,11 +6289,11 @@ var fileDescriptor_cf57597c3a9659a9 = []byte{ | |||
|
|
|||
| // Reference imports to suppress errors if they are not otherwise used. | |||
| var _ context.Context | |||
| var _ grpc.ClientConn | |||
| var _ grpc.ClientConnInterface | |||
There was a problem hiding this comment.
@lostluck I'm not sure why this line and L6296 were changed. Do you have any idea?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.