[BEAM-9743] Fix TFRecordCodec to try harder to read/write #11397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemin89
commented
Apr 11, 2020
sdks/java/core/src/main/java/org/apache/beam/sdk/io/TFRecordIO.java
Outdated
Show resolved
Hide resolved
|
R: @lukecwik |
lukecwik
requested changes
Apr 15, 2020
sdks/java/core/src/main/java/org/apache/beam/sdk/io/TFRecordIO.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/test/java/org/apache/beam/sdk/io/TFRecordIOTest.java
Outdated
Show resolved
Hide resolved
sdks/java/core/src/main/java/org/apache/beam/sdk/io/TFRecordIO.java
Outdated
Show resolved
Hide resolved
lukecwik
approved these changes
Apr 17, 2020
|
retest this please |
yirutang
pushed a commit
to yirutang/beam
that referenced
this pull request
Jul 23, 2020
* [BEAM-9743] Fix TFRecordCodec to try harder to read/write * [BEAM-9743] reverted header byte length check * [BEAM-9743] fix typo * [BEAM-9743] reflect comment : fix test + reformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadableByteChannel/WritableByteChannel specifies that a single read/write request might be ignored, and read/write from 0 bytes to n bytes, where n is buffer.remaining(), even if there's more contents/space left in the channel.
A similar issue has been pointed out and dealt with once. https://issues.apache.org/jira/browse/BEAM-5412?jql=text%20~%20%22tfrecord%22
But the same issue can happen for
headerandfooteras well, and when writing data.I recently encountered this issue when trying to switch from GZIP compression to ZSTD compression.
Make it try harder to read/write header/footer/data.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.