Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-9562] Fix output timestamp to be inferred from scheduled time when in the event time domain. #11402

Merged
merged 1 commit into from Apr 13, 2020
Merged

[BEAM-9562] Fix output timestamp to be inferred from scheduled time when in the event time domain. #11402

merged 1 commit into from Apr 13, 2020

Conversation

lukecwik
Copy link
Member

I copied the setting/validation logic from the SimpleDoFnRunner Timers implementation.

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status		 Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status		 --- Build Status
Build Status
Build Status		 Build Status
Build Status		 --- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status		 Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@lukecwik lukecwik mentioned this pull request Apr 13, 2020
Merged
4 tasks
@lukecwik
Copy link
Member Author

R: @boyuanzz @robertwb
CC: @ibzib We'll need this for 2.21.0 release.
CC: @mxm

@lukecwik
Copy link
Member Author

Run Java Flink PortableValidatesRunner Batch

@boyuanzz
Copy link
Contributor

Run Java Spark PortableValidatesRunner Batch

@lukecwik
Copy link
Member Author

Run Java Flink PortableValidatesRunner Streaming

@lukecwik
Copy link
Member Author

Run Java Spark PortableValidatesRunner Batch

boyuanzz
boyuanzz approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@boyuanzz boyuanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@boyuanzz boyuanzz merged commit a7f444f into apache:master Apr 13, 2020
@mxm
Copy link
Contributor

mxm commented Apr 13, 2020

Thanks for correcting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyuanzz boyuanzz boyuanzz approved these changes

Assignees
No one assigned
Labels
java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukecwik @boyuanzz @mxm