[BEAM-9815] Correct go integration test if clauses. #11524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Go PostCommit |
|
Run Go PostCommit |
|
Run Go PostCommit VR Flink |
|
Run Go PostCommit_VR_Flink |
|
Run Go PostCommit |
|
R: @robertwb |
robertwb
reviewed
Apr 27, 2020
sdks/go/container/boot.go
Outdated
| @@ -104,7 +104,7 @@ func main() { | |||
|
|
|||
| switch len(artifacts) { | |||
| case 0: | |||
| log.Fatal("No artifacts staged") | |||
| log.Printf("No artifacts staged. Attempting to run default \"worker\".") | |||
There was a problem hiding this comment.
Shouldn't this be fatal? There isn't a "default" worker.
There was a problem hiding this comment.
I can revert this line. It was mostly to explore if the artifacts got copied to the expected location anyway because the model was discovered that way in the first place.
robertwb
approved these changes
Apr 27, 2020
|
Run Go Postcommit |
|
I'll merge once I sanity check that we're back to "No artifacts" for the Dataflow tests, and otherwise passed. |
|
"No artifacts staged" state has been verified. Merging. |
bntnam
pushed a commit
to PolideaInternal/beam
that referenced
this pull request
May 5, 2020
String comparisons in the integration test script were not running as expected, meaning dev image pushes were not occuring for dataflow, leading to a separate issue. Doesn't fix dataflow,but brings it back to the "No artifacts staged" error, which requires a dataflow change to fix.
yirutang
pushed a commit
to yirutang/beam
that referenced
this pull request
Jul 23, 2020
String comparisons in the integration test script were not running as expected, meaning dev image pushes were not occuring for dataflow, leading to a separate issue. Doesn't fix dataflow,but brings it back to the "No artifacts staged" error, which requires a dataflow change to fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String comparisons in the integration test script were not running as expected, meaning dev image pushes were not occuring for dataflow.
This doesn't fix dataflow, but it brings it back to the "No artifacts staged" issue it was experiencing before.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.