[BEAM-9692] Add to/from_runner_api_parameters to WriteToBigQuery #11745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ifd969174d5a7744766173f35fd6b65a72ebfd924
rohdesamuel
force-pushed
the
beam-9692-bq-serial
branch
from
062117d
to
6cf105a
Compare
|
R: @robertwb can you take a look please? |
|
R: @pabloem thanks Pablo! |
|
retest this please |
|
thanks Sam! |
|
would you be able to create a JIRA to track this? I know it's a bit of a hassle, but in case someone wants a reference for this change |
|
(other than that, LGTM) |
|
you can use the same jira for the ptransformoverride |
rohdesamuel
changed the title
done |
|
Thanks Sam! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ifd969174d5a7744766173f35fd6b65a72ebfd924
The WriteToBigQuery only has a default implementation which can't reconstruct the original WriteToBigQuery.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.