[BEAM-9951] Using the builder pattern for Go synthetic config frontend #11747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
R: @lostluck |
lostluck
requested changes
May 18, 2020
| // restriction will always be output, so the number of splits will be in | ||
| // the range of [1, N] where N is the size of the original restriction. | ||
| InitialSplits int | ||
| numElements int |
There was a problem hiding this comment.
Note: Default encoding with JSON (or even future with beam.Schemas) will not encode unexported fields. You'll need to register a coder with beam.RegisterCoder if you want to ensure these get encoded properly.
Alternatively, having the fields be exported while still providing and recommending a builder is not unreasonable. Eg. Document on the type (as you have it) that the builder is recommended etc.
There was a problem hiding this comment.
Oh yea, forgot about that. I'll go with having them exported and just recommend a builder. Done.
| // always be output, so the number of splits will be in the range of [1, N] | ||
| // where N is the size of the original restriction. | ||
| InitialSplits int | ||
| outputPerInput int |
There was a problem hiding this comment.
Same comment here WRT the unexported fields being unserializable.
Instead of just creating SourceConfigs and StepConfigs, have a builder pattern to allow more user-friendly creation of those configs with defaults.
youngoli
force-pushed
the
sdf-implementation
branch
from
9db94d9
to
d032818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just creating SourceConfigs and StepConfigs, have a builder
pattern to allow more user-friendly creation of those configs with
defaults.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.