Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-9679] Flatten Kata for Go #11806

Merged
merged 1 commit into from
May 28, 2020
Merged

[BEAM-9679] Flatten Kata for Go #11806

merged 1 commit into from
May 28, 2020

Conversation

brucearctor
Copy link
Contributor

Adding a Flatten Kata for Go SDK.

@henryken
@damondouglas
@rionmonster

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status		 Build Status
Build Status
Build Status
Build Status		 Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status		 --- Build Status
Build Status
Build Status		 Build Status
Build Status		 --- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status		 Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

henryken
henryken suggested changes May 25, 2020
View reviewed changes
Copy link
Contributor

@henryken henryken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brucearctor, I've provided some comments.

learning/katas/go/Core Transforms/Flatten/Flatten/task-info.yaml Show resolved Hide resolved
learning/katas/go/Core Transforms/Flatten/Flatten/cmd/main.go Outdated Show resolved Hide resolved
lostluck
lostluck reviewed May 26, 2020
View reviewed changes
Copy link
Contributor

@lostluck lostluck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

learning/katas/go/Core Transforms/Flatten/Flatten/task.md Show resolved Hide resolved
@lostluck lostluck changed the title Flatten Kata for Go [BEAM-9679] Flatten Kata for Go May 26, 2020
henryken
henryken reviewed May 27, 2020
View reviewed changes
learning/katas/go/Core Transforms/Flatten/Flatten/task-info.yaml Outdated
@@ -0,0 +1,31 @@
// Licensed to the Apache Software Foundation (ASF) under one or more
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect comment syntax for yaml file.

learning/katas/go/Core Transforms/Flatten/Flatten/task.md Show resolved Hide resolved
henryken
henryken suggested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@henryken henryken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brucearctor, please help to fix the comment syntax.

henryken
henryken suggested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@henryken henryken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brucearctor, please help to fix the comment syntax.

@henryken henryken mentioned this pull request May 27, 2020
Merged
2 tasks
@brucearctor
Copy link
Contributor Author

@henryken --> I think got the comment syntax (# instead of //) addressed

Otherwise, looks good to go from comments (unless I accidentally closed any; hope I didn't)

@lostluck
Copy link
Contributor

Retest This Please

@lostluck
Copy link
Contributor

(jenkin's trigger)

@damondouglas
Copy link
Contributor

@henryken Related to Comment from PR 11803, would you mind to let me know when this is ready to update Stepik along with PR #11803?

Thank you @brucearctor for doing this.

@henryken
Copy link
Contributor

This looks good now. Thanks @brucearctor!

@lostluck, please help to merge this PR.
@damondouglas, once this is merged, you can merge this to your PR and then we can upload to Stepik.

@damondouglas
Copy link
Contributor

@henryken Just confirming these steps:

  1. @lostluck merges this PR [BEAM-9679] Flatten Kata for Go #11806 to master

  2. @damondouglas merges new changes from PR [BEAM-9679] Flatten Kata for Go #11806 to PR [BEAM-9679] Add a CoGroupByKey lesson to the Core Transforms section #11803

  3. @damondouglas uploads to Stepik

  4. @lostluck merges PR [BEAM-9679] Add a CoGroupByKey lesson to the Core Transforms section #11803 to master

@lostluck
Copy link
Contributor

@damondouglas That sounds correct to me as well, in order to avoid colliding stepik updates.

@lostluck lostluck merged commit 47ea112 into apache:master May 28, 2020
@henryken
Copy link
Contributor

Yes it is correct @damondouglas.

yirutang pushed a commit to yirutang/beam that referenced this pull request Jul 23, 2020
@brucearctor @yirutang
[BEAM-9679] Flatten Kata for Go (apache#11806)
1d6f861
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostluck lostluck lostluck left review comments

@henryken henryken henryken approved these changes

Assignees
No one assigned
Labels
learning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brucearctor @lostluck @damondouglas @henryken