New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BEAM-9869] adding self-contained Kafka service jar for testing #11846

Merged

chamikaramj merged 1 commit into apache:master from ihji:BEAM-9869

Jun 5, 2020

Contributor

ihji commented May 28, 2020

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang	SDK	Apex	Dataflow	Flink	Gearpump	Samza	Spark
Go		---	---		---	---
Java
Python		---			---	---
XLang	---	---	---		---	---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website
Non-portable
Portable	---		---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

Contributor Author

ihji commented May 28, 2020

R: @chamikaramj

Contributor Author

ihji commented May 28, 2020

This PR can be used with #11847

Contributor

chamikaramj commented May 29, 2020

LGTM. Thanks.

Contributor

chamikaramj commented May 29, 2020

Retest this please

1 similar comment

Contributor

chamikaramj commented May 29, 2020

Retest this please

Contributor

chamikaramj commented May 29, 2020

Run Java PreCommit

Contributor

chamikaramj commented May 29, 2020

Run Python2_PVR_Flink PreCommit

Contributor

chamikaramj commented May 29, 2020

Run Java PreCommit

Contributor

chamikaramj commented May 29, 2020

Run Website PreCommit

Contributor

chamikaramj commented May 29, 2020

Run Java PreCommit

Contributor

chamikaramj commented May 29, 2020

The error is from SolrIOTest but is regarding starting up ZooKeeper: https://builds.apache.org/job/beam_PreCommit_Java_Phrase/2265/testReport/org.apache.beam.sdk.io.solr/SolrIOTest/classMethod/

Can it be somehow related since we are introducing a Zookeeper config here as well ? (I'll be surprised if it is).

Contributor

chamikaramj commented May 29, 2020

Run Java PreCommit

1 similar comment

Contributor

chamikaramj commented Jun 1, 2020

Run Java PreCommit

Contributor

chamikaramj commented Jun 1, 2020

Still failing for the same reason "java.lang.RuntimeException: Could not get the port for ZooKeeper server"

Contributor Author

ihji commented Jun 1, 2020

Thanks, will look into it.


          [BEAM-9869] adding self-contained Kafka service jar for testing

e39632f

ihji force-pushed the BEAM-9869 branch from 0274cdf to e39632f Compare

June 2, 2020 05:26

probot-autolabeler bot added build java labels

Contributor Author

ihji commented Jun 2, 2020

Fixed solr test failure.

Contributor

chamikaramj commented Jun 3, 2020

Retest this please

1 similar comment

Contributor

chamikaramj commented Jun 3, 2020

Retest this please

Contributor

chamikaramj commented Jun 4, 2020

Run Java PreCommit

2 similar comments

Contributor

chamikaramj commented Jun 4, 2020

Run Java PreCommit

Contributor

chamikaramj commented Jun 4, 2020

Run Java PreCommit

Contributor

chamikaramj commented Jun 5, 2020

LGTM. Thanks.

chamikaramj merged commit a560ed2 into apache:master

ihji deleted the BEAM-9869 branch

March 30, 2021 01:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment