Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8602] Use shadow configuration for remaining DirectRunner dependencies #11917

Merged
merged 1 commit into from Jun 4, 2020

Conversation

TheNeuralBit
Copy link
Member

R: @lukecwik

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@TheNeuralBit
Copy link
Member Author

TheNeuralBit commented Jun 4, 2020

I grepped the build.gradle files to look for any other instances of adding the direct runner as a dependency dynamically, and couldn't find anything else:

❯ grep -iIrn "runners:direct-java" **/build.gradle | grep -v shadow
build.gradle:154:  dependsOn ":runners:direct-java:needsRunnerTests"
release/build.gradle:33:  dependsOn ":runners:direct-java:runQuickstartJavaDirect"
release/build.gradle:38:  dependsOn ":runners:direct-java:runMobileGamingJavaDirect"
runners/direct-java/build.gradle:154:// Generates :runners:direct-java:runQuickstartJavaDirect
runners/direct-java/build.gradle:157:// Generates :runners:direct-java:runMobileGamingJavaDirect
sdks/java/testing/load-tests/build.gradle:40:        : ":runners:direct-java")
sdks/java/testing/load-tests/build.gradle:78:  // to not hardcode any runner other than :runners:direct-java
sdks/java/testing/nexmark/build.gradle:35:        ?: ":runners:direct-java"
sdks/java/testing/nexmark/build.gradle:85:  // to not hardcode any runner other than :runners:direct-java
sdks/java/testing/nexmark/build.gradle:107://       Defaults to ":runners:direct-java"

@lukecwik lukecwik merged commit 010666c into apache:master Jun 4, 2020
yirutang pushed a commit to yirutang/beam that referenced this pull request Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants