New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10249] Populate state cache with initial values before appending #11997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Python2_PVR_Flink PreCommit |
Failures are unrelated to this change.
|
Also Dataflow tests are failing (unrelated):
|
tweise
approved these changes
Jun 12, 2020
Run Python2_PVR_Flink PreCommit |
Run Portable_Python PreCommit |
Run Python PreCommit |
When new values are added to a bag state, the cache handler in the Python SDK does not check whether the underlying state already has values present. Although the append operation will be sent to the backend, the cache itself will be corrupted because it returns only the newly appended values for get operations, not the values present before the append operation. This is a concern when restoring from a checkpoint but also when items are evicted from the cache.
mxm
added a commit
to lyft/beam
that referenced
this pull request
Jun 15, 2020
…th initial values before appending
mxm
added a commit
to lyft/beam
that referenced
this pull request
Jul 8, 2020
…te cache with initial values before appending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When new values are added to a bag state, the cache handler in the Python SDK
does not check whether the underlying state already has values present. Although
the append operation will be sent to the backend, the cache itself will be
corrupted because it returns only the newly appended values for get operations,
not the values present before the append operation.
This is a concern when restoring from a checkpoint but also when items are
evicted from the cache.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.