Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-9272] Remove obsolete portable SDF urns #12055

Merged
merged 1 commit into from Jun 23, 2020

Conversation

lukecwik
Copy link
Member

This also cleaned up the implementation logic within FnApiDoFnRunner since there isn't a sized and non-sized variant anymore.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang | SDK | Dataflow | Flink | Samza | Spark
--- | --- | --- | --- | --- | --- | ---
Go | Build Status | --- | Build Status | --- | Build Status
Java | Build Status | Build Status
Build Status | Build Status
Build Status
Build Status
Build Status | Build Status | Build Status
Build Status
Build Status
Python | Build Status
Build Status
Build Status
Build Status | Build Status
Build Status
Build Status | Build Status
Build Status | --- | Build Status
XLang | --- | --- | Build Status | --- | --- | Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

This also cleaned up the implementation logic within FnApiDoFnRunner since there isn't a sized and non-sized variant anymore.
@lukecwik
Copy link
Member Author

R: @youngoli
CC: @boyuanzz @robertwb

@lukecwik
Copy link
Member Author

Run Python PreCommit

Copy link
Contributor

@youngoli youngoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@lukecwik
Copy link
Member Author

Run Java PreCommit

@lukecwik
Copy link
Member Author

Run Python PreCommit

@lukecwik
Copy link
Member Author

Run Java PreCommit

1 similar comment
@lukecwik
Copy link
Member Author

Run Java PreCommit

@lukecwik lukecwik merged commit c22a2b0 into apache:master Jun 23, 2020
yirutang pushed a commit to yirutang/beam that referenced this pull request Jul 23, 2020
This also cleaned up the implementation logic within FnApiDoFnRunner since there isn't a sized and non-sized variant anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants