New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-9889] Populate local instance of InfluxDB with data #12167
[BEAM-9889] Populate local instance of InfluxDB with data #12167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition that can make for local development easier.
|
||
WORKDIR / | ||
|
||
RUN gsutil cp gs://apache-beam-testing-metrics/influxdb-backup.tar.gz . && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these backups available to non-committers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everyone on the Internet has read-only access to the bucket. Grafana dashboards are already public, so it doesn't change anything in terms of security or privacy
- mountPath: /backup | ||
name: shared-data | ||
- name: copy-to-gsc-bucket | ||
image: gcr.io/apache-beam-testing/gsutil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I can understand, we overwrite same backup each time. Given daily creation of backups and noone is paged when something goes wrong, this backup can be easily corrupted as well.
Though it is ok for current PR, it's best to add some rotation to backups, keeping 1-2 week old backups available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we overwrite the same backup each time, but the bucket has object versioning enabled. According to the doc:
You enable Object Versioning for a bucket. Once enabled:
Cloud Storage creates a noncurrent version of an object each time you perform an overwrite or delete of the live version
If you run gsutil ls -la gs://apache-beam-testing-metrics
, you will see all versions of the backup that were created so far.
I'm not well familiar with influx DB operations. It might be worth another pair of eyes taking a look at overall backup approach. |
R: @iemejia, I think you were interested in this change. Could you verify if everything is fine? |
I guess we can merge this since there're no more comments for quite some time. |
73dbfaf
to
6bd4aa5
Compare
Yeah, let's merge it then. Thanks @Ardagan |
The goal of these changes is to make the process of creating and modifying Grafana dashboards easier by populating InfluxDB database with real data.
Two workflows have been implemented:
[1] https://cloud.google.com/storage/docs/object-versioning
[2] https://cloud.google.com/storage/docs/lifecycle
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.