New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10474] Relax matchers to match display data from the specific tests, not from all options. #12288
Conversation
@TobKed - question related to failed "Build python wheels / Build wheels on macos-latest" (https://github.com/apache/beam/pull/12288/checks?check_run_id=879924787) I do not see any logs other that "This check failed" message. How do we debug this? |
"This check failed" is really weird, I never seen this before. Looks like GitHub Actions issue. @aaltay do you have permission to rerun workflow? If not please push some changes e.g. rebase. It should re-trigger run and hopefully we will get more info. |
I found information:
It is visible in Annotations section here: |
|
@tysonjh - Gradle is failing with "java.io.IOException: No space left on device" errors. Link to failing tests: https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Commit/12004/ @chamikaramj @ihji test_expand_kafka_read and test_external_transform are failing on Flink. Link to failing tests: https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Commit/5854/ |
Restarting tests, since this failures are not related to the specific flake this PR is fixing. And triaged the issues in the previous comment. |
Run Portable_Python PreCommit |
Run Python2_PVR_Flink PreCommit |
1 similar comment
Run Python2_PVR_Flink PreCommit |
@chamikaramj @ihji test_expand_kafka_read and test_external_transform are failing on Flink. Link to failing tests: (https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Phrase/304/) -- same error as before. This looks like an issue, I will find the JIRA issue or file a new one. |
Run Python2_PVR_Flink PreCommit |
|
…from all options.
Re-pushed to pick up (#12303) |
Now all the external transform tests in Python2_PVR_Flink are timing out instead. I'm thinking about either increasing the timeouts to these tests, or removing them since they might be redundant (XVR_Flink has its own postcommit already). |
@ibzib - May I ignore the failure and merge this change? I think this change is good (passing other tests). And it would be good to merge this as it address another flakiness. |
Yes, I think the failure is fine to ignore. |
Sure. What is the process to do it?
I see it is still happens: https://github.com/apache/beam/actions/runs/175737977 |
Thank you. There is really not much of a process. Anyone can signup and edit the wiki. After you signup/login, you can go to the page I linked, edit and add a small section about these tests. Does it make sense?
|
This was fixed AFAICT by running some Jenkins jobs to clean up the local storage. Sorry about the delayed response. |
I created PR with documentation for GItHub Actions CI #12405 |
This is a follow up to https://github.com/apache/beam/pull/11744/files. Newly added pipeline option breaks these tests because
contains_inanyorder
requires all items to match the matcher list. Changed this tohas_items
which reverses the relationship and require each matcher to match an item.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.