Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-8473] Fix minor issue in the Generator type hint #12300

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

adesormi
Copy link
Contributor

The Generator type hint should only contain the YieldType. SendType and ReturnType are supposed to be left None and warnings are triggered if this is not the case.
The code was checking twice "send_type" and never "return_type". The condition and the warning message were not in line.
This PR aims at fixing this minor bug.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@aaltay aaltay requested a review from udim July 23, 2020 18:17
@udim
Copy link
Member

udim commented Jul 23, 2020

Thanks for this!
I'll update the title with the related bug (https://issues.apache.org/jira/browse/BEAM-8473)

@udim udim changed the title Fix minor issue in the Generator type hint [BEAM-8473] Fix minor issue in the Generator type hint Jul 23, 2020
@udim
Copy link
Member

udim commented Jul 23, 2020

Opened bug for PythonDocker failure: https://issues.apache.org/jira/browse/BEAM-10567

@udim udim merged commit 576d164 into apache:master Jul 23, 2020
@adesormi adesormi deleted the patch-1 branch July 25, 2020 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants