New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BEAM-10200] Respect profile_memory option and add memory profiler to… #12562
Conversation
R: @angoenka |
retest this please |
Run Portable_Python PreCommit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also change the behavior from periodic heap dump to i think on demand heap dump.
Shall we also summarize how it should be used?
from guppy import hpy | ||
self.hpy = hpy() | ||
self.hpy.setrelheap() | ||
except ImportError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's log the import failure
Do you mean the deletion of MemoryReporter? I don't think it is used anywhere but we can also keep it if it is useful for users. |
Codecov Report
@@ Coverage Diff @@
## master #12562 +/- ##
===========================================
+ Coverage 34.47% 82.30% +47.83%
===========================================
Files 684 455 -229
Lines 81483 54583 -26900
Branches 9180 0 -9180
===========================================
+ Hits 28090 44927 +16837
+ Misses 52972 9656 -43316
+ Partials 421 0 -421 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If MemoryProfiler is not used then we don't have to keep it around.
LGTM
Can you please take a look at failing tests. |
retest this please |
@angoenka I think this PR can be merged |
… sdk worker
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).[BEAM-XXX] Fixes bug in ApproximateQuantiles
, where you replaceBEAM-XXX
with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.