[BEAM-10545] Added the inspector of PCollections and pipelines #12626
Conversation
KevinGG
force-pushed
the
BEAM-10545-pr4
branch
from
c714895
to
a52a2fa
Compare
|
R: @prodonjs PTAL! |
| } | ||
|
|
||
| render(): React.ReactNode { | ||
| const pcollListItems = Object.entries(this.props.pcolls).map( |
There was a problem hiding this comment.
Just a nit, but you could probably move this and the onClick function out to private methods to make the logical separation a bit more readable. Or, since there is no state to this component, you could write it as a pure functional component that accepts props and returns the React node.
There was a problem hiding this comment.
Thanks! I've moved the logic out into private functions.
| } | ||
|
|
||
| renderOptions(): React.ReactNode { | ||
| if (this.props.model.inspectableType === 'pcollection') { |
There was a problem hiding this comment.
nit you can reduce the nesting level for the pcollection case if you put put the inverse condition first and short-circuit the return for the empty span.
There was a problem hiding this comment.
Inverted the condition and the return statements.
Codecov Report
@@ Coverage Diff @@
## master #12626 +/- ##
==========================================
- Coverage 40.22% 40.22% -0.01%
==========================================
Files 454 454
Lines 53669 53670 +1
==========================================
Hits 21587 21587
- Misses 32082 32083 +1
Continue to review full report at Codecov.
|
|
R: @pabloem PTAL, thx! Do we have a way to re-trigger |
|
Run Python PreCommit |
|
Run Python2_PVR_Flink PreCommit |
1. Added the InteractiveInspector component and its sub components. The hierarchy can be found in the code documentation. 2. The component allows listing all user defined pipelines and PCollections in the kernel of the current notebook session, displaying pipeline graphs, and visualizing PCollection data.
KevinGG
force-pushed
the
BEAM-10545-pr4
branch
from
18b1dc5
to
dc3144d
Compare
|
Rebased to head to resolve failures in Python tests. |
|
Run Typescript PreCommit |
|
@KevinGG - so IIUC, all of these elements will eventually be used once the side panel is activated here: - is that correct? |
Yes. The next PR will bring in all the boilerplates to use all these components. |
hierarchy can be found in the code documentation.
PCollections in the kernel of the current notebook session,
displaying pipeline graphs, and visualizing PCollection data.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.